Multiple Rasengans.

ID:1308383
 
Jun 30 2013, 10:49 am
(See the best response by Jittai.)
Code:
mob/Stat()
    statpanel("Skills")
    stat(src.Jutsus)

obj/Cards
    icon='Cards.dmi'
    layer=MOB_LAYER+1000
    var/list/Jutsu=list()
    Click()
        if(src.Owner==usr)
            usr<<"You click [src]. Select an Attack to use from the Skills tab."
            usr.Jutsus+=src.Jutsu
            return


Problem description:Problem is the Rasengan Obj spam adds into the skills panel.

Jun 30 2013, 10:57 am (Edited on Jun 30 2013, 11:03 am)
We tried:

Click()
        if(src.Owner==usr)
            usr<<"You click [src]. Select an Attack to use from the Skills tab."
            //usr.Jutsus+=src.Jutsu
            for(var/obj/Cards/Skills/S in src.Jutsu)
                usr.Jutsus+=S


But i get the following runtime:

runtime error: type mismatch: Rasengan (/obj/Cards/Skills/Rasengan) += Rasengan (/obj/Cards/Skills/Rasengan)
proc name: Click (/obj/Cards/Click)
source file: Main.dm,294
usr: Runney001 (/mob)
src: Naruto (/obj/Cards/MySlots/Slot1)
call stack:
Naruto (/obj/Cards/MySlots/Slot1): Click(null, "mapwindow.map", "icon-x=19;icon-y=19;left=1;scr...")

line 294 is usr.Jutsus+=src.Jutsu

Any assistance would be greatly appreciated. Thanks in advance

Edit: Interestingly enough, despite this Runtime error only one Rasengan Obj is added to the Skills
Jun 30 2013, 12:25 pm
In response to Runney001
Runney001 wrote:
We tried:

> Click()
>       if(src.Owner==usr)
>           usr<<"You click [src]. Select an Attack to use from the Skills tab."
>           //usr.Jutsus+=src.Jutsu
>           for(var/obj/Cards/Skills/S in src.Jutsu)
>               usr.Jutsus+=S

But i get the following runtime:

runtime error: type mismatch: Rasengan (/obj/Cards/Skills/Rasengan) += Rasengan (/obj/Cards/Skills/Rasengan)
proc name: Click (/obj/Cards/Click)
source file: Main.dm,294
usr: Runney001 (/mob)
src: Naruto (/obj/Cards/MySlots/Slot1)
call stack:
Naruto (/obj/Cards/MySlots/Slot1): Click(null, "mapwindow.map", "icon-x=19;icon-y=19;left=1;scr...")

line 294 is usr.Jutsus+=src.Jutsu

Any assistance would be greatly appreciated. Thanks in advance

Edit: Interestingly enough, despite this Runtime error only one Rasengan Obj is added to the Skills

Shot in the dark here, but what I'm understanding from line 294 is that you are adding the list to itself with the "+=" operator, which then deletes the list on the right hand side of the operator. But the list on the right hand side, is both lists because they are one and the same...
Jun 30 2013, 2:24 pm
Is mob/Jutsus[] initialized before you add to it?
Jun 30 2013, 2:33 pm
In response to Kaiochao
Kaiochao wrote:
Is mob/Jutsus[] initialized before you add to it?

mob/var/list/Jutsus=list() is defined yes

Jun 30 2013, 2:35 pm
The error described in post #1 tells me that it's null at the time of addition.

I'm still not clear on the original issue, though. What's spam adding?
Jun 30 2013, 2:37 pm
In response to Kaiochao
Kaiochao wrote:
The error described in post #1 tells me that it's null at the time of addition.

I'm still not clear on the original issue, though. What's spam adding?

The obj/Rasengan adds repeatedly. The user ends up having 10+ obj/Rasengan in their skills/list

Jun 30 2013, 2:39 pm
In response to Runney001
Does this just happen if the player repeatedly clicks on the thing?
Jun 30 2013, 2:55 pm
Nope
Jun 30 2013, 3:20 pm
Best response
Mob's jutsus isn't a list.
Jun 30 2013, 3:29 pm
In response to Jittai
Jittai wrote:
Mob's jutsus isn't a list.

Yeah that was the problem all along. I can't believe I overlooked such an obvious detail. Thanks a lot everyone for your responses.
Jun 30 2013, 3:44 pm
In response to Runney001
Runney001 wrote:
mob/var/list/Jutsus=list() is defined yes
Where did this come from?
Jun 30 2013, 4:46 pm
I assumed I defined the list/Jutsu.. turns out i didn't