Map saving bug...

ID:935543
 
Aug 17 2012, 9:35 am (Edited on Aug 17 2012, 11:17 am)
Keywords: building, game, icon, mapsave
(See the best response by Albro1.)
<> 
proc
    SaveObjects()
        var/savefile/F = new ("Map.sav")
        var/list/L = new
        for(var/obj/O in world)
            if(!O.owner) continue
            if(O.owner)
                O.saved_x = O.x
                O.saved_y = O.y
                O.saved_z = O.z
                O.saved_owner = O.owner
                O.saved_object = O
            L += O
        F[""] << L


proc/LoadObjects()
    var/savefile/F = new ("Map.sav")
    var/list/L = new
    F[""] >> L
    if(!L) return
    for(var/obj/O in world)
    for(var/obj/O in L)
        O.loc = locate(O.saved_x,O.saved_y,O.saved_z)
        O.owner = (O.saved_owner)
        O = (O.saved_object)</b>

obj
    var
        saved_x
        saved_y
        saved_z
        saved_owner
        saved_object
mob/verb
     SaveObjects()
         SaveObjects()
     LoadObjects()
         LoadObjects()</b>

The problem is that the code does not save the layering. I know I've made the object's layer right, because I've used the wording codes. Like
wooden_floor layer=TURF_LAYER...And when the map saves and than you load it, the floor layer is over an OBJ_Layer which is a higher layer. Can anyone tell me why?


Aug 17 2012, 9:39 am
use the 
 tags please.
Aug 17 2012, 11:21 am
Alright, 
 tags were added.
Aug 17 2012, 11:28 am
Well you might want to actually name the variable in the save file, and I'm not sure if you can save lists in the way you want to use them.
Aug 17 2012, 11:59 am
I've obviously tried.
Aug 17 2012, 12:03 pm
Best response
Try using obj/New() to set the layer, because loading objects creates new instances of them.
Aug 17 2012, 2:43 pm
All right, I'll try it right now!
Aug 17 2012, 2:50 pm (Edited on Aug 17 2012, 2:56 pm)
Okay, so, I've fixed it. But, I've tried the obj/New() and gotten a proc error. But, thank you anyways!
Aug 17 2012, 2:51 pm
In response to Audio freak XD
Mind posting explaining how you fixed it for future referance? It's fine if not.
Aug 17 2012, 7:49 pm
It's too embarrassing to say NNAAAAHH. ):
Aug 17 2012, 7:52 pm (Edited on Aug 17 2012, 10:53 pm)
But, it's pretty funny. So I went to put a var in 
obj/var
called saved_layer. I've installed it to map save and load, it turned out, Map Save was set backwards. :/

With that var writing the object's layers. Example

O.layer=O.saved_layer//Backwards! oops!
Aug 18 2012, 8:31 am
In response to Audio freak XD
Lol. Thank you for posting that.
Aug 18 2012, 9:51 am
No problem!
Aug 18 2012, 11:52 am
This isn't really completely relevant, but you may want to include a type of obj that isn't saved, that way you have a type reserved for things like projectiles, things you wouldn't want saved.
Aug 18 2012, 1:58 pm (Edited on Aug 18 2012, 2:04 pm)
...Wow! You've obviously failed to read the code. If the object has a owner, it saves...so therefore, projectiles will not be saved. :/
Aug 18 2012, 1:59 pm
 
proc
    SaveObjects()
        var/savefile/F = new ("Map.sav")
        var/list/L = new
        for(var/obj/O in world)
            if(!O.owner) continue
            if(O.owner)
                O.saved_x = O.x
                O.saved_y = O.y
                O.saved_z = O.z
                O.saved_owner = O.owner
                O.saved_object = O
            L += O
        F[""] << L
Aug 18 2012, 2:32 pm
In response to Audio freak XD
I did read it through but a while ago, I just popped back here quick and didn't re-read.
Aug 18 2012, 3:02 pm
Okay, anyway, yeah! It doesn't save any other object, except building objects, that players built.
Aug 18 2012, 3:03 pm
Well that's good then.
Aug 18 2012, 8:44 pm
Yep!