Blur effect bugs

ID:2754524
 
Dec 29 2021, 12:02 am (Edited on Dec 30 2021, 10:28 pm)
Not a bug
BYOND Version:514
Operating System:Windows 10 Pro
Web Browser:Chrome 96.0.4664.110
Applies to:Dream Seeker
Status: Not a bug
This is not a bug. It may be an incorrect use of syntax or a limitation in the software. For further discussion on the matter, please consult the BYOND forums.
Version: 514.1571

With the shadowcasting & blur:

https://cdn.discordapp.com/attachments/706611098828144825/ 925641839623684096/unknown.png

https://cdn.discordapp.com/attachments/706611098828144825/ 925641929495048192/unknown.png

No blur shadowcasting:
https://cdn.discordapp.com/attachments/706611098828144825/ 925642753428303904/unknown.png

https://cdn.discordapp.com/attachments/706611098828144825/ 925642842490150952/unknown.png

/proc/make_triangle_image(x1,y1,x2,y2,x3,y3, l = FLOAT_LAYER)
    var/image/triangle_image = new /mutable_appearance()
    triangle_image.icon = 'icons/effects/triangle.dmi'
    triangle_image.icon_state = ""
    triangle_image.layer = l
    triangle_image.plane = 19
    triangle_image.transform = transform_triangle(x1,y1,x2,y2,x3,y3)
    triangle_image.filters += filter(type="blur", size=2)
    return triangle_image.appearance


From what i see, its not rendering the shadows properly and it seems to apply alpha into it, when the image alpha is 255.

* This did not only happen to me but to other ss13 servers that did matrix changes and applied blur.

PS:
I changed the type from:

var/image/opacity_image
to
var/atom/movable/opacity_image
which where on the client.image, now the effect works properly when added filters INDIVIDUALLY, if you try to add plane_masters to it, it wont work

Jan 3 2022, 4:10 pm
Can you distill this to a test case?

From what I'm seeing in your snippet I don't think this is a bug. You definitely don't want shadow triangles to blur individually; this should be done at a plane level.
Jan 5 2022, 6:58 am
Yes, i fixed that bug applying it to a whole plane AND making it an /atom/movable instead of images, which solved the lag by 99% because doing that way would even crash my pc. I'll get a test case for you
Jan 5 2022, 7:10 am
Jan 12 2022, 1:30 pm
In response to Comicao1
Sorry I didn't get back to you sooner on this, but I can't use that link. Mediafire is really no longer usable as a download site.
Jan 12 2022, 4:21 pm
In response to Lummox JR
I sent another link to your DMs
Jan 14 2022, 2:07 pm
I got the test project, although I'm unclear on how it's supposed to work. What are the verbs for? Where is the lighting and the blur handled?
Jan 14 2022, 2:23 pm
In response to Lummox JR
They are handled on raytracing.dm and i commented a few parts to check how it was supposed to be, all the other verbs and etc are not related, i just use that for testing many and many things, everything about the bug is on raytracing.dm the other two are older versions of it
Jan 14 2022, 4:10 pm
From what I'm seeing there isn't a bug here. You shouldn't have the blur on the individual triangles and you don't want the alpha mask on those either. All of this should be handled at the level of a plane master.
Jan 15 2022, 7:55 am
Yes, that was my fix to it, i just found its behaviour weird, and it might be something important in its internal code
Jan 15 2022, 3:09 pm
Nothing weird about it; the triangle method is for building up a complex shape. You've broken it up into smaller pieces and blurred them individually, which won't look the same at all.
Jan 15 2022, 3:09 pm
Lummox JR resolved issue (Not a bug)