Assigning verbs?

Page: 1 2
ID:2038390
 
Feb 17 2016, 9:13 am
(See the best response by MrStonedOne.)
so im in the process of redoing a horrible messy admin code file where it has all the different admin powers. the problem is the distribution of the verbs are more or less set in a category and repeatedly copy and pasted for each other type of admin that has those verbs. So example gm1 would have mute gm2 would have a copy paste of the verb mute gm 3 copy and paste of mute etc what is the simplest way to distribute the verbs for each different level of admin without having to have 20 mute verbs and instead just it referencing the 1 mute verb as the source for it. Example: gm 1 2 and 3 have mute and get it from the only mute verb instead of copy and pasting the mute verb code 3 times

Feb 17 2016, 9:23 am
For starters, you could use only a single mute verb to handout to GMs, instead of using multiple different copies. Then you could remove the unused versions afterwards.
Feb 17 2016, 9:45 am
yeh but how
Feb 17 2016, 9:48 am
Best response
if you change it to be client procs, you can then have the admin checks on client.New() and have it add the verbs to the client's verb list using client.verbs += /client/proc/name.

a verb is just a proc that is automatically added to the verb list, so procs can have set name / set category etc.

see https://github.com/tgstation/-tg-station/blob/master/code/ modules/admin/admin_verbs.dm for an example (note, per our copy right license, to use our code in your projects, you MUST make your project open source as well, but you can use it as a design example as long as you don't actually use any of the code)
Feb 17 2016, 8:49 pm
If I get what you are saying correctly, you are trying to distribute different verbs for different levels the way I did it was I assigned by path, so for example
var
    list/admins = list("Mastergamerxxx")//There are probable countless mistakes and I wouldn't just copy and paste, I am just trying to give the general layout.
var
    list/moderators = list("Dragonpearl123")
admin/verb
    Reboot()
        set category="Admin"
        switch(input("Reboot the world?")in list("Yes","No"))
            if("Yes")
                world.Reboot()//This reboot verb should be okay
moderator/verb
    Show_Image(f as file)
        set category = "Admin"
        world<< f
        world<< ""//just to show a random image for the lols

client
    New()
        if(key in admins)//if the persons key is in the list
            verbs.Add(typesof(/admin/verb))//give them these verbs.
            verbs.Add(typesof(/moderator/verb))//You can add more than one type of verb
        if(key in moderators)//same down here
            verbs.Add(typesof(/moderator/verb))
        ..()

Remember this is just a basic layouts that probably has all kinds of bugs because I did this in like two minutes.
Feb 17 2016, 9:49 pm
Hard-coding admin names in the code is a terrible, terrible idea.
Feb 17 2016, 9:53 pm
In response to Lummox JR
how so?
Feb 17 2016, 9:54 pm
In response to Dragonpearl123
Things like that are best handled in a configuration file. It's not hard to write something to read such a file (especially with the new text handling routines in 510), and that way your admin system is much, much more flexible.

Various SS13 branches have been doing this sort of thing for a while.
Feb 17 2016, 9:56 pm
In response to Lummox JR
Goodness me, I have much to learn!
Feb 18 2016, 8:49 am
yeah but say i have a list of admin powers right? i want to be able to pick and choose the verbs so i dont need to have a section for each power.say admin was to have ban unban mute then if moderator needs the mute verb i shouldnt have to make a preset category for what the mod gets by copy and pasting the mute code i just want to be able to take it from the admin section instead
Feb 18 2016, 8:54 am
In response to Mastergamerxxx
I'm not sure I follow. But there are lots of ways to categorize admin verbs and levels of admins. Maybe you could describe what sort of system you want.
Feb 18 2016, 3:00 pm
i just wanted a way to give verbs to different levels of admin/gms without having to put a duplicate of a verbs code under each level of admin that i wanted that level to also have. EX: admin and GM1 having mute verb without me having to copy and paste mob/verb/mute() and all the code for both ranks
Feb 18 2016, 3:12 pm
In response to Mastergamerxxx
I'm pretty sure I just did it up there, although as Lummox JR said 'Hard-coding admin names in the code is a terrible, terrible idea.'
It doesnt have to be under mob/verb/mute() in fact I dont think it should be. it should have its town designated path that way you could just add a certain path so mob/admin/verb/mute() and give all the verbs under admin to someone etc...
Feb 18 2016, 3:51 pm
ok i finally got it exactly as i wanted
Feb 18 2016, 3:52 pm
In response to Mastergamerxxx
How did you do it?
Feb 18 2016, 7:20 pm
its a temporary check system but it does work wonders for the tests i ran with the verb version
mob
    proc
        AdminGMCheck()
            if(src.gm2)
                src.verbs += /mob/AdminPowers/verb/Mute_Wand
                src.verbs += /mob/AdminPowers/verb/Kick
            if(src.gm3)
                src.verbs += /mob/AdminPowers/verb/Mute_Wand
                src.verbs += /mob/AdminPowers/verb/Kick
            if(src.gm4)
                src.verbs += /mob/AdminPowers/verb/Mute_Wand
                src.verbs += /mob/AdminPowers/verb/Repopulate
                src.verbs += /mob/AdminPowers/verb/Kick
Feb 18 2016, 8:33 pm
Having separate vars for each GM type isn't really a great way to go. Typically all you'll need are either a GM level (one var), or bitflags defining their powers (also one var).
Feb 18 2016, 8:52 pm
yeah i kno thats why i said its temporary
Feb 19 2016, 5:57 am
Also, you can just keep the GM verbs under a list for each level and add them when you reach a higher level. What I mean is: you're adding every single verb of the previous GM level and adding new ones on top. You could just do something like GM2_verbs = GM1 + other verbs. Obviously that's just pseudo-code and you need to store verbs granted on each level on a associative list and whatnot.
Feb 19 2016, 7:33 am
oh well not every level have exactly the same previous verbs the last had its all random
Page: 1 2