Will some1 plz tell me whats wrong with this NPC Battle Cod

ID:266988
 
Sep 24 2002, 7:06 pm
mob/monster
var/mob/M
New()
.=..()
spawn(1)
Wander()
proc/Wander()
while(src)
if (M in oview(5))
step_towards(src,M)
else
step_rand(src)
for(M in view(src))
break
sleep(5)
spawn(40)
Wander()
Bump(mob/M)
if (istype(M,/mob))
Hit(M)
proc/Hit(mob/M)
var/damage = rand(1,Level)
M.HP -= damage
usr << "Blah!"
M.Death()
Barbarian
name = "Barbarian"
icon = 'enemy-barbarian.dmi'
HP = 10
Max_HP = 10
Level = 2
EXP_give = 5 //set the vars
Speed = 3
Defence = 3
Weapon = 0
Sep 24 2002, 7:12 pm
You tell us.
Sep 24 2002, 7:15 pm
In response to Garthor
If I knew i would!
Sep 24 2002, 7:16 pm
In response to Elliot Leonhart
But basically the "Barbarians" won't attack me...
Sep 24 2002, 7:16 pm
In response to Elliot Leonhart
mob
Barbarian
New()
spawn() Wander()
Sep 24 2002, 7:22 pm
In response to Garthor
They still don't attack me!
Sep 24 2002, 7:24 pm
In response to Elliot Leonhart
usr << "Blah!" should be M << "Blah!"

Never use usr in procs unless if you know exactly what you're doing. And no offense, but you need some experience before you know when to use usr in a proc and when not to.
Sep 24 2002, 7:31 pm
In response to Garthor
i've used plenty of usr procs in my game so far already though, anyway they still won't attack me.
Sep 24 2002, 7:33 pm
In response to Elliot Leonhart
if (M in oview(5))
step_towards(src,M)

You haven't defined M...

for(var/mob/Player/M in oview(5))
step_towards(src,M)
break
Sep 24 2002, 7:39 pm
In response to Garthor
omg it works, and i was thikin u couldn't get it. Thanx big time...i'll remember u when i'm finished with the game!
Sep 24 2002, 7:40 pm
In response to Elliot Leonhart
I coulda gotten it, but I was busy pointing out other flaws =)

Don't worry, all our games are messed when we first start.
Sep 24 2002, 10:38 pm
In response to Garthor
If the program works with usr does that mean it'll work in a multiplayer environment???
-Spoon
Sep 24 2002, 11:20 pm
In response to Spoon
Spoon wrote:
If the program works with usr does that mean it'll work in a multiplayer environment???
-Spoon

See this discussion:

UsrIsEvil