Character won't load.

ID:139930
 
Jul 15 2010, 10:26 am
Code:
        Load()
            if(src.mob.savefile1)
                var/savefile/load
                load = new ("Player Saves/[mob.ckey]/Save File 1.sav")
                load["mob"] >> src.mob
                load["x"] >> src.mob.x
                load["y"] >> src.mob.y
                load["z"] >> src.mob.z
                src<<"Account loaded. [src.mob], [src.mob.x], [src.mob.x], [src.mob.z]"
            if(src.mob.savefile2)
                var/savefile/load
                load = new ("Player Saves/[mob.ckey]/Save File 2.sav")
                load["mob"] >> src.mob
                load["x"] >> src.mob.x
                load["y"] >> src.mob.y
                load["z"] >> src.mob.z
                src<<"Account loaded. [src.mob], [src.mob.x], [src.mob.x], [src.mob.z]"
            if(src.mob.savefile3)
                var/savefile/load
                load = new ("Player Saves/[mob.ckey]/Save File 3.sav")
                load["mob"] >> src.mob
                load["x"] >> src.mob.x
                load["y"] >> src.mob.y
                load["z"] >> src.mob.z
                src<<"Account loaded. [src.mob], [src.mob.x], [src.mob.x], [src.mob.z]"


        Save()
            if(!src)return
            if(!src.mob)return

            if(src.mob.savefile1)
                var/savefile/save
                save = new ("Player Saves/[mob.ckey]/Save File 1.sav")
                save["mob"] << src.mob
                save["x"] << src.mob.x
                save["y"] << src.mob.y
                save["z"] << src.mob.z
                src<<"Successfully saved to slot 1"
            if(src.mob.savefile2)
                var/savefile/save
                save = new ("Player Saves/[mob.ckey]/Save File 2.sav")
                save["mob"] << src.mob
                save["x"] << src.mob.x
                save["y"] << src.mob.y
                save["z"] << src.mob.z
                src<<"Successfully saved to slot 1"
            if(src.mob.savefile3)
                var/savefile/save
                save = new ("Player Saves/[mob.ckey]/Save File 3.sav")
                save["mob"] << src.mob
                save["x"] << src.mob.x
                save["y"] << src.mob.y
                save["z"] << src.mob.z
                src<<"Successfully saved to slot 1"


Problem description:
It seems like the character is saving because when I load it up, I've set it to show me the some variables of the loaded character and they seem just about right. The only problem is that my character isn't appearing at his saved (x,y,z) coordinates.

Jul 15 2010, 10:32 am
Horrible design having everything repeated 3 times
And you have to set it using a locate(), setting each coordinate separately doesn't work if your location is null.
Jul 15 2010, 10:46 am
In response to Falacy
Falacy wrote:
Horrible design having everything repeated 3 times
And you have to set it using a locate(), setting each coordinate separately doesn't work if your location is null.

Any points on how I can reduce the code? and I tried

src.Move(locate(src.mob.x,src.mob.y,src.mob.z))


but my character still wont move away from the title screen.
Jul 15 2010, 12:39 pm
In response to AbdelJN
AbdelJN wrote:
> src.Move(locate(src.mob.x,src.mob.y,src.mob.z))


That's just setting them to the location they're already in

but my character still wont move away from the title screen.

If they're already at a title screen, and not a null/black screen, then setting their location 1 coordinate at a time should work.

To get rid of the repetitive pointlessness mob/var/savefile should be a # 1-3 to be used:
save = new ("Player Saves/[mob.ckey]/Save File [mob.savefile].sav")
Jul 15 2010, 1:36 pm
In response to Falacy
Thanks ( : Now I have ideas on how to simplify some of my other codes. Anyways here's the new code and I tried changing the coordinates on by one but I get no results just like before.

client
    proc
        Load()
            if(src.mob.savefile>=1 && src.mob.savefile<=3)
                Load2()
        Load2()
            var/savefile/load
            load = new ("Player Saves/[mob.ckey]/Save File [mob.savefile].sav")
            load["mob"] >> src.mob
            //load["name"] >> src.mob.namet_
            var/last_x
            var/last_y
            var/last_z
            load["last_x"] >> last_x
            load["last_y"] >> last_y
            load["last_z"] >> last_z
            src<<"Account loaded. [src.mob], [last_x], [last_y], [last_z]"
            //src.mob.loc = locate(last_x, last_y, last_z)
            usr.loc=locate(last_x,last_y,last_z)
            usr.z=last_z
            usr.x=last_x
            usr.y=last_y
Jul 15 2010, 2:00 pm
In response to AbdelJN
Try locating src.mob instead of usr.
You should pretty much never use usr.
Jul 15 2010, 2:10 pm
In response to Falacy
Falacy wrote:
Try locating src.mob instead of usr.
You should pretty much never use usr.

Ooh I figured out the problem, it didn't have to do with src/usr it was mainly a variable problem that kept me on the title screen. Thanks for the advice though. [:
Jul 16 2010, 6:38 pm
In response to AbdelJN
I'd listen about the "src/usr" deal. Also, saving an entire "mob" is bad practice. You're creating many problems for your self in the future, particularly file sizes that will amass very quickly when you start saving icons and overlays/underlays, etc.
Jul 16 2010, 7:35 pm
In response to Teh Governator
It is not bad practice you follow the same straight thinking as Falacy and in laymens terms you are both right while being at the same time very wrong.

See you guys mention systems where you write everything manually. AKA

F["var1"] << var1

multiple times to save what you want to save, with that way you basically do the exact same thing as saving the entire "mob" directory.

And as for the "bloating of files when you add in icons" thats not true you simply do the same steps you do for your system except in a more refined way, you remove the overlays from the saves and you simply have additional variables in which to recreate the character (which i presume is what you do anyway for your system)

So to the poster. Yes that code works for the most part

and because i feel like it heres another tadbit of code for you.

mob
    Write(var/savefile/F) //writes the file pretty straight forward
        ..()
        F.dir.Remove("icon","overlays","underlays") /*this removes the entire directory for icon,overlays and any underlays that may exist.
    this is also covered in the actual save proc below but due to a DM language bug overlay and icon are prewiped before save and this cleans it*/
        F["SavedX"] << x
        F["SavedY"] << y
        F["SavedZ"] << z

    Read(var/savefile/F)
        ..()
        usr.Base_Build()
        usr.Overlay_Build()
        F["SavedX"] >> x
        F["SavedY"] >> y
        F["SavedZ"] >> z

client/proc/Load(var/slot)
    var/savefile/F = new("Player Saves/[copytext(ckey,1,2)]/[ckey].sav")
    F["Slot[slot]"] >> mob

client/proc/Save()
    var/txtfile = file("Player Saves/[copytext(ckey,1,2)]/[ckey].txt")
    var/savefile/F = new("Player Saves/[copytext(ckey,1,2)]/[ckey].sav")
    mob.icon = null
    mob.overlays = null
    F["Slot[usr.slot]"] << src.mob
    fdel(txtfile)
    F.ExportText("/",txtfile)
    mob.Base_Build()
    mob.Overlay_Build()

//heres the load launcher
mob/verb
        LoadSlotOne() //execute to load slot one
        
            usr.client.Load(1) //the "one" tells the load proc that you want to load slot one and thus only requires one load proc

//naturally with thise code it requires an additional verb named "slot" to determine which slot there saved to and this will work for unlimited amount of save slots in ONE save file and will organize them into a clean directory format of Root>Player Saves>(First key letters)>Actual keys
Jul 16 2010, 7:43 pm
In response to Midgetbuster
Midgetbuster wrote:
It is not bad practice you follow the same straight thinking as Falacy and in laymens terms you are both right while being at the same time very wrong.

See you guys mention systems where you write everything manually. AKA

F["var1"] << var1

Not really. I pretty much do exactly what you have written below. I remove overlays, underlays and all icons from being saved. All icons and overlays/underlays are regenerated anew on login. My savefiles typically stay under a single KB. He is saving entire atoms and all their variables including icons. I've seen the same system let save files grow into 50mb+ per player.
Jul 16 2010, 7:52 pm
In response to Teh Governator
True, ive seen that to thats why my code snippet applies the auto wiping of overlays etc.

and has procs to then rebuild it
Jul 17 2010, 4:02 pm
In response to Teh Governator
Teh Governator wrote:
Not really. I pretty much do exactly what you have written below. I remove overlays, underlays and all icons from being saved. All icons and overlays/underlays are regenerated anew on login. My savefiles typically stay under a single KB. He is saving entire atoms and all their variables including icons. I've seen the same system let save files grow into 50mb+ per player.

Saving the entire mob is the proper way to do things. You then modify Write() and Read() so that it does not save data you don't want saved (assuming you can't just declare it tmp).

You're basically saying, "I have seen people cut themselves with knives, so I'll stick with these sharp rocks thankyouverymuch."