ID:148490
 
turf
Battle_Grass
icon = 'Turfs.dmi'
icon_state="Grass01"
Enter()
if (!usr.client){return}
if(!usr.Bnum)
var/C=rand(1,50)
if(C<5)
var{M1;M2;M3;M4;R}
R=rand(1,4)
if(R==1){M1=new/mob/monsters/Monster0}
else{..()}
if(R==2){M2=new/mob/monsters/Monster1}
else{..()}
if(R==3){M3=new/mob/monsters/Monster2}
else{..()}
usr.Rbattle(M1,M2,M3,M4)
return 1

I don't know if the proble is in here I'm not getting any errors. This is for a turn based random combat. When attack by Monster0 there is a graphic. But when attacked by the others it doesn't show a graphic. Icon and icon states are correct I've checked.
ZZZZZZZZZZzzzzzzzzz 3 hours and nothing
In response to Codesterz
Codesterz wrote:
ZZZZZZZZZZzzzzzzzzz 3 hours and nothing

Okay, I have two problems right off the bat with this.

First off, you put usr in your Enter() proc. I believe I've already told you specifically not to do that, and I've told enough other people that you should have seen it by now, and the people I haven't told, someone else has. So you have no excuse for doing such a thing. Duh.

Second, you bumped a post after only 3 hours on a quiet forum. Bumping is something to be done only after at least a day has passed and your thread has been pushed off the main page and you very much need an answer.

On neither front did you put a lot of thought into what you were doing.

Lummox JR
In response to Lummox JR
Sorry... If the usr goes the whole think gives me a thousand errors. I really am wanting the problem fixed so I can continue on with the game. then next what is wrong with usr?
In response to Codesterz
Codesterz wrote:
Sorry... If the usr goes the whole think gives me a thousand errors. I really am wanting the problem fixed so I can continue on with the game. then next what is wrong with usr?

It gives you errors because you're obviously replacing it with the wrong thing. But the reason it's wrong is that the movement procs aren't always initiated by a verb or other player action. usr is a player who just did something, like decide to move; the thing that tries to enter (or just did enter, since you should really be using Entered() instead of Enter()) may be any movable atom including objs and other mobs.

Dream Tutor: usr Unfriendly

Among other things, that will show you the right way to set up an Entered() proc.

Lummox JR